Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDMA vs DMA interrupt bit discrepancies #2193

Closed
Dominaezzz opened this issue Sep 19, 2024 · 1 comment · Fixed by #2196
Closed

GDMA vs DMA interrupt bit discrepancies #2193

Dominaezzz opened this issue Sep 19, 2024 · 1 comment · Fixed by #2196
Labels
bug Something isn't working peripheral:dma DMA Peripheral status:needs-attention This should be prioritized

Comments

@Dominaezzz
Copy link
Collaborator

Whilst drafting a PR to enumset-ify the DMA interrupts I noticed some discrepancies in the interrupts of the RegisterAccess implementations.

is_in_done() different between GDMA and PDMA

GDMA says it's IN_SUC_EOF.
I2S PDMA and SPI PDMA say it's IN_DONE. (This is probably the wrong one)

is_out_done() different between GDMA and PDMA

SPI PDMA and GDMA says it's OUT_TOTAL_EOF.
I2S PDMA says it's OUT_EOF. (This is probably the wrong one)

out_eof inconsistency (in both GDMA and PDMA)

listen_out_eof()/unlisten_out_eof()/is_listening_out_eof says it's OUT_TOTAL_EOF.
is_out_eof_interrupt_set()/reset_out_eof_interrupt() says it's OUT_EOF.
Hard to say which is wrong here at a glance.

@Dominaezzz Dominaezzz added bug Something isn't working status:needs-attention This should be prioritized labels Sep 19, 2024
@bjoernQ
Copy link
Contributor

bjoernQ commented Sep 19, 2024

I think it was better aligned in the beginning and diverged at some point

Would be good to have things more aligned but I also remember that in some cases things named the same were apparently not behaving the same way for ESP32/ESP32-S2 vs other chips - but I agree that in those cases the function names should at least not suggest what is used under the hood but what it is expected to do / check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working peripheral:dma DMA Peripheral status:needs-attention This should be prioritized
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants