Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: ZIP artifacts should be downloaded to IDF_TOOLS_PATH/dist #268

Open
georgik opened this issue May 31, 2023 · 2 comments
Open

Windows: ZIP artifacts should be downloaded to IDF_TOOLS_PATH/dist #268

georgik opened this issue May 31, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@georgik
Copy link
Contributor

georgik commented May 31, 2023 •
edited
Loading

Bug description

espup install downloads ZIP diles to location under rustup.

Downloading file 'C:\Users\georgik\.rustup\toolchains\esp\riscv32-esp-elf\esp-12.2.0_20230208/riscv32-esp-elf.zip' from 'https://github.com/espressif/crosstool-NG/releases/download/esp-12.2.0_20230208/riscv32-esp-elf-12.2.0_20230208-x86_64-w64-mingw32.zip'

Prefered location should be %IDF_TOOLS_PATH%/dist. This way idf-installer and esp-idf tools can pick up the already downloaded archive.
@georgik georgik added the bug Something isn't working label May 31, 2023
@georgik georgik changed the title Windows deployment and PATH update should be based on path in IDF_TOOLS_PATH Windows deployment and PATH update should be based on path in IDF_TOOLS_PATH with backslashes May 31, 2023
@georgik georgik changed the title Windows deployment and PATH update should be based on path in IDF_TOOLS_PATH with backslashes Windows: ZIP artifacts should be downloaded to IDF_TOOLS_PATH/dist May 31, 2023
@SergioGasquez
Copy link
Member

SergioGasquez commented May 31, 2023 •
edited
Loading

Bug description

espup install downloads ZIP diles to location under rustup.

Downloading file 'C:\Users\georgik\.rustup\toolchains\esp\riscv32-esp-elf\esp-12.2.0_20230208/riscv32-esp-elf.zip' from 'https://github.com/espressif/crosstool-NG/releases/download/esp-12.2.0_20230208/riscv32-esp-elf-12.2.0_20230208-x86_64-w64-mingw32.zip'

Prefered location should be %IDF_TOOLS_PATH%/dist. This way idf-installer and esp-idf tools can pick up the already downloaded archive.

This was decided in #154, we don't assume that the user has any IDF installed and all the installation takes place under $HOME/.rustup/toolchains/<name>

@SergioGasquez
Copy link
Member

The point of this issue is to reuse what ESP-IDF has already installed if the user has IDF_TOOLS_PATH defined.

@SergioGasquez SergioGasquez added enhancement New feature or request and removed bug Something isn't working labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@georgik @SergioGasquez