Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages with no tags are ignored at build time #39

Open
arabello opened this issue Feb 20, 2024 · 4 comments
Open

Packages with no tags are ignored at build time #39

arabello opened this issue Feb 20, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@arabello
Copy link
Collaborator

Currently packages with not tags are ignore as consequence of #28, specifically because the io-ts decoder defines a NonEmptyArray.

We might revisit our initial choice of excluding packages with no tags from the domain.

@smeech
Copy link

smeech commented Jun 9, 2024

I note the package espanso/hub#35 referred to in #28, while listed in the hub, still just shows a blank page, despite @federico-terzi's addition of tags.
See Issue: espanso/hub#114

@AucaCoyan
Copy link
Member

I'm not sure if this keeps happening. I searched all the packages and all of them have at least one tag.
Might need to submit a dummy pkg to test if it's ignored by the front end.

I rather have packages with at least one tag than no tag at all

@arabello
Copy link
Collaborator Author

arabello commented Oct 7, 2024

Yes, it keeps happening. Fortunately, for only one package.

I searched all the packages and all of them have at least one tag.

Do you mean on the hub? Packages with no tags are ignored at build time: the built frontend will have packages with at least one tag by design

@AucaCoyan
Copy link
Member

On the repo espanso/hub.

Yes, it keeps happening. Fortunately, for only one package.

allright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants