esp_lvgl_port broken by espressif/button v4.0.0 dependency (BSP-628)

[atanisoft]

Board

any

Hardware Description

Any

IDE Name

N/A

Operating System

N/A

Description

Recent release of espressif/button v4.0.0 contains breaking API changes and is breaking esp_lvgl_port v2.3.2. Example compilation failure below:

managed_components/espressif__esp_lvgl_port/src/lvgl8/esp_lvgl_port_knob.c:59:35: error: too few arguments to function 'iot_button_create'
   59 |         encoder_ctx->btn_handle = iot_button_create(encoder_cfg->encoder_enter);
      |                                   ^~~~~~~~~~~~~~~~~
In file included from managed_components/espressif__button/include/iot_button.h:10,
                 from managed_components/espressif__esp_lvgl_port/include/esp_lvgl_port_knob.h:22,
                 from managed_components/espressif__esp_lvgl_port/include/esp_lvgl_port.h:18,
                 from managed_components/espressif__esp_lvgl_port/src/lvgl8/esp_lvgl_port_knob.c:10:

For now I've pinned espressif/button to v3.5.0 to not consume the breaking API changes.

Sketch

N/A

Other Steps to Reproduce

No response

I have checked existing issues, README.md and ESP32 Forum

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[espzav]

Hi @atanisoft, Thank you for reporting this issue, I am sorry about that. Please, set the version of button component in your YML file like this:

button: ">=2,<4.0"