Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC_DESC_2_2: Ensure each of the listed endpoints has a tag attribute and the tag attributes are not the same (CON-1504) #1235

Closed
bilalahmaddev opened this issue Jan 10, 2025 · 8 comments

Comments

@bilalahmaddev
Copy link

bilalahmaddev commented Jan 10, 2025

Describe the bug
Ensure each of the listed endpoints has a tag attribute and the tag attributes are not the same
Environment

  • ESP-Matter Commit Id: relase1.3

  • ESP-IDF Commit Id: 5.2.1

  • SoC (eg: ESP32 or ESP32-C3): ESP32-S3

  • Device Logs (Please attach the log file):
    TC-DESC-2-2_2025_01_10_14_15_04.log

  • Host Machine OS:

  • Host Machine Python version:

  • Commissioner app and versions if present: certification tool Version: 2.10.2+spring2024

  • Home hub app and versions if present:

  • Commissioner's logs if present:

This is certification blocker for us.

@github-actions github-actions bot changed the title TC_DESC_2_2: Ensure each of the listed endpoints has a tag attribute and the tag attributes are not the same TC_DESC_2_2: Ensure each of the listed endpoints has a tag attribute and the tag attributes are not the same (CON-1504) Jan 10, 2025
@bilalahmaddev
Copy link
Author

@dhrishi @VaishaliAvhale can you please look into this and others I created they are certification blockers for us.

@jonsmirl
Copy link
Contributor

Multiple identical endpoints now have to be differentiated via TAGs in the descriptor. This requires a enabling the TAGLIST feature on the Descriptor cluster.

#1141

@bilalahmaddev
Copy link
Author

@jonsmirl Thanks. From where I can find namespaces required for TagList, link mentioned in specification is not public:
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/namespaces

@bilalahmaddev
Copy link
Author

Got it there is a document for it in specification documents.

@bilalahmaddev
Copy link
Author

which namespace should be used for endpoints of type on off plugin and dimmable plugin?

@jonsmirl
Copy link
Contributor

I don't think it matters, they just have to be different.

@bilalahmaddev
Copy link
Author

bilalahmaddev commented Jan 15, 2025

@jonsmirl is this a correct way to add Tag to each endpoint descriptive cluster TagList:

const Descriptor::Structs::SemanticTagStruct::Type ep0TagList[] = {
{.namespaceID = 0x00,
.tag = 0x00}};

const Descriptor::Structs::SemanticTagStruct::Type ep1TagList[] = {
{.namespaceID = 0x01,
.tag = 0x01}};

did this for each endpoint

cluster_t* descriptor = cluster::get(output_channels_endpoint, Descriptor::Id);
descriptor::feature::taglist::add(descriptor);

SetTagList(0, chip::Span(ep0TagList));
SetTagList(1, chip::Span(ep1TagList));

I am not getting any cluster id in logs:

image

Looks like issue with descriptive cluster:
image

@bilalahmaddev
Copy link
Author

My bad I was calling SetTagList() before matter started. closing as issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants