From ee84b11589348b5d6be9249b8298248fe3c4f245 Mon Sep 17 00:00:00 2001 From: "peter.marcisovsky" Date: Fri, 10 Jan 2025 15:31:43 +0100 Subject: [PATCH] feat(esp_tinyusb): Update comments as per review recommendations --- device/esp_tinyusb/CHANGELOG.md | 2 +- device/esp_tinyusb/Kconfig | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/device/esp_tinyusb/CHANGELOG.md b/device/esp_tinyusb/CHANGELOG.md index 6c0152e1..a12544bb 100644 --- a/device/esp_tinyusb/CHANGELOG.md +++ b/device/esp_tinyusb/CHANGELOG.md @@ -1,6 +1,6 @@ ## [Unreleased] -- esp_tinyusb: Added configuration for NCM device NTB buffers +- esp_tinyusb: Added possibility to configure NCM Transfer Blocks (NTB) via menuconfig ## 1.6.0 diff --git a/device/esp_tinyusb/Kconfig b/device/esp_tinyusb/Kconfig index d5a562c4..dc86a0e1 100644 --- a/device/esp_tinyusb/Kconfig +++ b/device/esp_tinyusb/Kconfig @@ -293,7 +293,8 @@ menu "TinyUSB Stack" range 1 4 help Number of NTB buffers for reception side. - Can be increased to improve performance with the cost of additional RAM requirements. + Can be increased to improve performance and stability with the cost of additional RAM requirements. + Helps to mitigate "tud_network_can_xmit: request blocked" warning message when running NCM device. config TINYUSB_NCM_IN_NTB_BUFFS_COUNT int "Number of NCM NTB buffers for transmission side" @@ -302,7 +303,8 @@ menu "TinyUSB Stack" range 1 4 help Number of NTB buffers for transmission side. - Can be increased to improve performance with the cost of additional RAM requirements. + Can be increased to improve performance and stability with the cost of additional RAM requirements. + Helps to mitigate "tud_network_can_xmit: request blocked" warning message when running NCM device. config TINYUSB_NCM_OUT_NTB_BUFF_MAX_SIZE int "NCM NTB Buffer size for reception size"