Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development CLI: Remove targets record file on Clean. #2231

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

AmmarAbouZor
Copy link
Member

This PR closes #2227

It provides Removing record file entirely on the start of any clean job instead of trying to update the record file, making clean command more reliable because updating the record file may fail more often than removing it.

Remove record file entirely on the start of an clean job instead
of trying to update the record file, making clean command more reliable
because updating the record file may fail more often than removing it.
@AmmarAbouZor AmmarAbouZor requested a review from marcmo February 17, 2025 15:35
@AmmarAbouZor AmmarAbouZor added the build-cli Used to run integration tests for the build cli tool when a PR includes changes to the cli tool label Feb 17, 2025
Copy link
Member

@marcmo marcmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmmarAbouZor AmmarAbouZor merged commit ceabc14 into esrlabs:master Feb 17, 2025
4 checks passed
@AmmarAbouZor AmmarAbouZor deleted the dev-cli-reliable-clean branch February 17, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-cli Used to run integration tests for the build cli tool when a PR includes changes to the cli tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development CLI: Remove checksum file on all clean commands
2 participants