Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for UglifyJS parser (with Spidermonkey transform) #2

Open
michaelficarra opened this issue Aug 21, 2013 · 14 comments
Open

Comments

@michaelficarra
Copy link
Member

No description provided.

@michaelficarra
Copy link
Member Author

Ugh. It looks like UglifyJS2 only supports taking SpiderMonkey ASTs as input, not creating them. I'll open up an issue and link to it.

edit: mishoo/UglifyJS#275

@RReverser
Copy link
Member

@michaelficarra I've closed issue with mishoo/UglifyJS#526 and already used esfuzz (with some adaptations) for generative testing of UglifyJS->SpiderMonkey AST convertor itself. Check out mishoo/UglifyJS#527 for details (hopefully it helps).

@michaelficarra
Copy link
Member Author

I saw. Nice job. Care to open a PR when the new functionality is in an UglifyJS release?

@RReverser
Copy link
Member

But you're using git://... dependencies for parsers, is it necessary to wait for the release?

@michaelficarra
Copy link
Member Author

Ah, you're right. No it's not. Feel free to send a PR any time.

@RReverser
Copy link
Member

I'd like to, and even started rewriting adapter to CoffeeScript, but the problem I have is actually the same as I mentioned in michaelficarra/CoffeeScriptRedux#315 (btw, could you please have a look at it?).

This project uses Makefiles and I use Windows. So we don't match each other (at least, without installing and configuring that Cygwin stuff) :(

That's why I love JS-based builders.

@vendethiel
Copy link

This project uses Makefiles and I use Windows. So we don't match each other (at least, without installing and configuring that Cygwin stuff) :(

You don't need to, really. Just get some gnu stuff, or a git install that comes with all of this. Cygwin is one of the reason people hate windows - cmd.exe is not great, but at least it's not cygwin (others will suggest to use powershell).

@RReverser
Copy link
Member

I have required subset of MinGW, but still it behaves pretty different from real Linux shell and sometimes fails (at least, I couldn't build CoffeeScriptRedux nor this project).

@lydell
Copy link

lydell commented Aug 23, 2014

I’ve tried many times, in many different ways to get make running on Windows, but never made it. (Then I switched to GNU/Linux and I haven’t looked back a second.)

@vendethiel
Copy link

Just install msysgit and voilà, it works.

@RReverser
Copy link
Member

Nope - it doesn't :P At least for this project or CoffeeScriptRedux.

@vendethiel
Copy link

Well, I remember fixing Redux's makefile once upon a time. Or maybe it was the "coffeescript-project" structure.

@lydell
Copy link

lydell commented Aug 23, 2014

Just install msysgit and voilà, it works.

As far as I remember, make isn't even included in msysgit.

@vendethiel
Copy link

Oh, isn't it? Must be in ruby's toolset-thingie,then. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants