Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Naming Updates Prevent Searching Schemas #1426

Open
dyaffe opened this issue Jan 20, 2025 · 2 comments
Open

Collection Naming Updates Prevent Searching Schemas #1426

dyaffe opened this issue Jan 20, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@dyaffe
Copy link
Member

dyaffe commented Jan 20, 2025

Problem
After the updates to how we name collections, users can no longer search for schemas in the capture edit search box.

It would be ideal to change how we show collection names in that portion of the UI to show both the schema and table name so that users could see and search for schemas as well as table names.

@travjenkins
Copy link
Member

travjenkins commented Jan 21, 2025

🤦 ... yeah... I did not think about this at all.

Tech Details

We'll need to see how this can work with the MUI table we're using to show the list. We might have to pull filtering out of the table and into stand alone code.

May want to use "server mode" for filtering https://mui.com/x/react-data-grid/filtering/server-side/

I think we might have to manually filter now. This will be interesting to figure out. Setting the filterModel manually does NOT make a call to the "filter changed" function. We might end up having to just manually mess with the rows data manually while altering the filter and no longer even tell MUI about the filtering.

This could end up having some weird impacts since we are using pagination. However, we use a lot of the same things on other tables so I am pretty sure it will be okay.

Bonus Points

This could be the main area where we need MUI to use eval... so without this we might find a solid way to not have it include eval at all and help increase safety a bit.

@travjenkins
Copy link
Member

We should also handle the second request from #1445 at this time

When a user searches for a specific binding, it would be nice to show the first one in the filtered list automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants