Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to User Management #1457

Open
4 of 7 tasks
dyaffe opened this issue Feb 7, 2025 · 4 comments
Open
4 of 7 tasks

Improvements to User Management #1457

dyaffe opened this issue Feb 7, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@dyaffe
Copy link
Member

dyaffe commented Feb 7, 2025

Background
Our user management feature is very rough and could be improved in a few ways:

  • Only designated users should be able to invite people to an account
  • We should allow for deleting users
  • Billing contacts should be a thing. They should be able to see the billing tab.

Proposal

  • 1. Change the button "Manage Invitations" to "Add Users"
  • 2. Change the "Revoke" button to "Remove"
  • 3. After clicking "Add Users", we should change the "Generate Invitation" button to "Create Invite Link"
  • 4. After creating an invite link, we should change the "URL" button to "Invite Link"

New stuff beyond content changes

  • 6. After clicking "Add Users", we should add two checkboxes that should be selectable when creating an invite link: (1): Can Invite Users - default (2): Billing Contact - not defaulted. Existing users should have both selected though.
  • 7. If someone is invited with the "Can Invite Users" permission, they should be able to see the "Add Users" section.
  • 8. If someone is invited with the "Billing Contact" permission, they should be able to see the billing tab.

Created estuary/flow#1928 to handle creating the new permissions.

@kiahna-tucker
Copy link
Member

I wanted to give a quick preview of what replacing URL with Copy Invite Link looks like and, in the event it is too verbose, offer some suggestions.

Copy Invite Link button | Requested change

Image

Copy Invite button

Image

Invite Link button

Image

@dyaffe
Copy link
Member Author

dyaffe commented Feb 10, 2025

"INVITE LINK" looks good -- thanks!

@kiahna-tucker
Copy link
Member

Questions

  1. Would you like to update label of the Revoke CTA on the organization membership table and the data sharing table to Remove? Or just change the organization membership table CTA? I would assume both button labels should be adjusted but would like to confirm.

  2. Would you like the Active Invitations table header to be changed to Active Invite Links or Active Invites? Or are you comfortable with the language as is?

  3. Broadly speaking, would you like to replace instances of invitation with invite?

Reference

Active invitations table | Empty

Image

@dyaffe
Copy link
Member Author

dyaffe commented Feb 10, 2025

  1. Both works
  2. Active Invite Links sounds good
  3. I'm not super opinionated about invitation vs invite -- we've had some users that didn't understand how our invitation UX works and this change is mostly geared at just explicitly spelling out what everything does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants