-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sources can be duplicated when similar sources for different chunks on !sources command #39
Comments
Hey, I don't see any duplicated sources. |
Ah, I missed the one that are actually real duplicated. EDIT: my bad, I don"t see duplicate in fact, I confuse the source inside the answer and the actual sources with !sources. |
@pedevineau Can you confirm you're OK with the current |
What we can be done is to add an anchor in links for each chunks. For example
Even if the anchor does not exist, it can give the user a hint of why this is the actual same URL. Let me know if you have better idea. |
How do we choose the titles related to chunks? My suggestion would be: let us return the title of the sheet once with the url. So it will be easy to deduplicate |
The title of a chunk, is the tittle of the sheet it comes from. The subtitle(context) is the path towards that chunks in the sheet, which is composed by the successive subtitles meet before reaching the chunk. The subtitle is the string that enable us to deduplicate (we also use a hash of the chunk as a unique identifier internally). But again, there are no duplicated chunks, they are already deduplicated in the backend. |
Yes I know there is no deduplicates of chunks, I was considering dedupling sheets, because at the end every url targets the same page. The anchor system doesn't work in general, because our chunks are not always related to the DILA webpage anchors, are them? |
Yes, you're right, the anchor idea was just to give a visual hint. |
We should de-duplicate similar sources.
The text was updated successfully, but these errors were encountered: