Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends on deprecated library sodiumoxide #24

Open
jonassmedegaard opened this issue Nov 1, 2021 · 11 comments
Open

depends on deprecated library sodiumoxide #24

jonassmedegaard opened this issue Nov 1, 2021 · 11 comments

Comments

@jonassmedegaard
Copy link

The sodiumoxide project is now deprecated: sodiumoxide/sodiumoxide@5bb1dfd

@tasn
Copy link
Member

tasn commented Nov 5, 2021

I think it's not deprecated in terms of DO NOT USE, but rather: it's now feature complete, no?

@jonassmedegaard
Copy link
Author

Right, that is my understanding as well.

I am no crypto expert, but seem to read between the lines, however, that what the author describes as having "vastly changed" includes maturity of implementations in native Rust, which I would expect to have both size, speed, and stability improvements.

Seems the Dalek libraries (and crates based on those) are the most popular in the Rust community nowadays.

@tasn
Copy link
Member

tasn commented Nov 5, 2021

The problem is that we can't only care about quality, but we also need to care about compatibility with the algorithms we use (libsodium ones).

Dalek looks great though! I wonder if there's a sodium compatibility layer!

@jonassmedegaard
Copy link
Author

Perhaps this: https://crates.io/crates/crypto_box

@tasn
Copy link
Member

tasn commented Nov 13, 2021

Main questions are:

  1. is it worth it?
  2. Compatibility.

@Xiretza
Copy link
Contributor

Xiretza commented Sep 3, 2022

sodiumoxide is now completely archived and will thus no longer receive security fixes; it should be replaced.

@tasn
Copy link
Member

tasn commented Sep 4, 2022

:|

OK, I'll try to find some time to take a look, thanks!

@barathrm
Copy link
Contributor

barathrm commented Apr 8, 2023

I'm looking into finally upstreaming libetebase into openSUSE, and just discovered this one again during the automated cargo audit that's run.

Friendly bump 🤗

@tasn
Copy link
Member

tasn commented Apr 9, 2023

There's nothing wrong with sodiumoxide I believe, it's just "no longer developed". I don't know what it actually means in terms of security, but given that it's just a thin wrapper around libsodium, I'm not that concerned. It's going to be quite a bit of work changing to a new implementation, which I don't have time for unfortunately. Especially given the questionable benefits.

@mainrs
Copy link

mainrs commented Sep 19, 2023

sodiumoxide is now completely archived and will thus no longer receive security fixes; it should be replaced.

This does not seem to be the case:

https://github.com/sodiumoxide/sodiumoxide/blob/3057acb1a030ad86ed8892a223d64036ab5e8523/README.md?plain=1#L3-L5

This seems to mean that new API surface in libsodium will not be implemented in the crate. But security fixes that arise will be fixed accordingly on the already existing API surface.

@Xiretza
Copy link
Contributor

Xiretza commented Sep 19, 2023

That message is from before the repo was archived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants