-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Couldn't find translations for ru-RU #3882
Comments
file name is |
Possibly related to #3404 ? |
Browser - Firefox all is ok |
Yea, I mentioned that if ru-RU file is not available it should always fall back to |
Having some trouble reproducing this. Related: https://github.com/ether/etherpad-lite/blob/develop/src/static/js/html10n.js#L186 |
hrm, the OP is another dev so you could just push back to him to add some debug/logging.
He seems to know how to do basic stuff so prolly fine to push back to him.
It might be that we are sending the error but actually handling it gracefully?
…-----Original message-----
From: Luke Williams <[email protected]>
Sent: Sunday 19th April 2020 14:00
To: ether/etherpad-lite <[email protected]>
Cc: John McLear <[email protected]>; Comment <[email protected]>
Subject: Re: [ether/etherpad-lite] Error: Couldn't find translations for ru-RU (#3882)
Having some trouble reproducing this.
Related: https://github.com/ether/etherpad-lite/blob/develop/src/static/js/html10n.js#L186
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe. <http://dl.efa-project.org/static/1x1spacer.gif>
[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#3882 (comment)", "url": "#3882 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
|
ok, i am able to replicate in firefox using ru-MD on the home page. The issue appears to go a little deeper than originally thought. ru-RU -> ru is being handled correctly as is (by line 186 linked above). However its then getting set back to en by this line here https://github.com/ether/etherpad-lite/blob/develop/src/static/js/l10n.js#L7 studying further. |
…ble locales Before this change, we simply generated an error. For example: - if the browser sent 'ru-RU', but Etherpad has 'ru' available, select 'ru'; - if the browser sent 'zh', but we have 'zh-hans' available, use 'zh-hans'. Fixes ether#3882.
…ble locales Before this change, we simply generated an error. For example: - if the browser sent 'ru-RU', but Etherpad has 'ru' available, select 'ru'; - if the browser sent 'zh', but we have 'zh-hans' available, use 'zh-hans'. Fixes #3882.
Bug: ether#6129 Follows-Up: ether#3882 Change-Id: Ie3fcec84948fde36fa12448d5eabaf05f79f1283
fixes ether#6129 Bug: ether#6129 Bug: ether#6144 Follows-Up: ether#3882 Change-Id: Ie3fcec84948fde36fa12448d5eabaf05f79f1283
fixes ether#6129 Bug: ether#6129 Bug: ether#6144 Follows-Up: ether#3882 Change-Id: Ie3fcec84948fde36fa12448d5eabaf05f79f1283
fixes ether#6129 Bug: ether#6129 Bug: ether#6144 Follows-Up: ether#3882 Change-Id: Ie3fcec84948fde36fa12448d5eabaf05f79f1283
Hi everyone!
The text was updated successfully, but these errors were encountered: