Error: Couldn't find translations for ru-RU

[alekseyr1987]

Hi everyone!

[JohnMcLear]

[JohnMcLear]

file name is ru.json

[JohnMcLear]

Possibly related to #3404 ?

[alekseyr1987]

Browser - Chrome
Browser language - Russian
HTTP_ACCEPT_LANGUAGE - ru-RU,ru;q=0.9,en-US;q=0.8,en;q=0.7

and

[alekseyr1987]

Browser - Firefox
Browser language - English
HTTP_ACCEPT_LANGUAGE - en,de;q=0.7,en-US;q=0.3

all is ok

[JohnMcLear]

Yea, I mentioned that if ru-RU file is not available it should always fall back to language.substring(0,1)+".json", it's an easy fix I have put someone on it.

[iquidus]

Having some trouble reproducing this.

Related: https://github.com/ether/etherpad-lite/blob/develop/src/static/js/html10n.js#L186

[JohnMcLear]

hrm, the OP is another dev so you could just push back to him to add some debug/logging. He seems to know how to do basic stuff so prolly fine to push back to him. It might be that we are sending the error but actually handling it gracefully?

…

-----Original message----- From: Luke Williams <[email protected]> Sent: Sunday 19th April 2020 14:00 To: ether/etherpad-lite <[email protected]> Cc: John McLear <[email protected]>; Comment <[email protected]> Subject: Re: [ether/etherpad-lite] Error: Couldn't find translations for ru-RU (#3882) Having some trouble reproducing this. Related: https://github.com/ether/etherpad-lite/blob/develop/src/static/js/html10n.js#L186 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. <http://dl.efa-project.org/static/1x1spacer.gif> [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#3882 (comment)", "url": "#3882 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

[iquidus]

ok, i am able to replicate in firefox using ru-MD on the home page. The issue appears to go a little deeper than originally thought. ru-RU -> ru is being handled correctly as is (by line 186 linked above). However its then getting set back to en by this line here

https://github.com/ether/etherpad-lite/blob/develop/src/static/js/l10n.js#L7

studying further.