Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Updated Button Component from Design System also Fixes Text Overflow Issues #13523

Closed

Conversation

jenish-thapa
Copy link

Pull Request: Implement Updated Button Component from Design System

Description

This PR addresses the issue where the text on the 'Previous' and 'Next' buttons was coming out of the box in certain languages, like Russian, and was touching the underline. This was especially noticeable on the page ethereum.org/en/developers/docs/evm/opcodes/.

Changes Made

  • Implemented the updated button component from the design system, as per the Figma file provided here.
  • Adjusted the styles to ensure the text does not touch the underline and stays within the button boundaries.
  • Tested the implementation across different languages to ensure consistent rendering.

Screenshots

  • Light Mode:

image

  • Dark Mode:

Screenshot from 2024-07-28 21-07-15

How to Test

  1. Navigate to ethereum.org/en/developers/docs/evm/opcodes/.
  2. Scroll down to the 'Previous' and 'Next' buttons.
  3. Verify that the text stays within the button boundaries and does not touch the underline in various languages.

Additional Context

  • This change aims to provide a more sustainable fix by aligning with the design system.

Issue Link

Fixes #13405

Feel free to assign the task to me. Looking forward to your feedback!

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit f21825a
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66a665efbb3107000878e649
😎 Deploy Preview https://deploy-preview-13523--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 42 (🔴 down 9 from production)
Accessibility: 93 (no change from production)
Best Practices: 91 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jenish-thapa
Copy link
Author

Hi @wackerow, please check the preview. Also please let me know if any modifications required

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 29, 2024
@corwintines corwintines self-assigned this Sep 23, 2024
@nloureiro
Copy link
Contributor

@jenish-thapa Oh, this looks very good. Thank you!!!!

I was testing, and they should not collapse. I'm double-thinking and testing on your dev preview and prefer higher buttons over one on top of the other.

So, from the design side, I think we should make them:

  • always side by side
  • make the all the same height > height of the biggest one.
  • alight the content to the center

Something like this:
Screen Shot 2024-09-23 05 21 24 PM

What do you think?

@nloureiro nloureiro added feature ✨ This is enhancing something existing or creating something new and removed Status: Stale This issue is stale because it has been open 30 days with no activity. labels Sep 23, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 23, 2024
@nloureiro
Copy link
Contributor

@jenish-thapa are you still up to finishing this based on my last comments?

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jan 15, 2025
iusx added a commit to iusx/ethereum-org-website that referenced this pull request Feb 2, 2025
@wackerow
Copy link
Member

@all-contributors please add @jenish-thapa for ideas

Copy link
Contributor

@wackerow

I've put up a pull request to add @jenish-thapa! 🎉

wackerow added a commit that referenced this pull request Feb 26, 2025
[ShadCN]: Fix #13405 and end #13523 use shadcn
@github-actions github-actions bot added the abandoned This has been abandoned or will not be implemented label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned This has been abandoned or will not be implemented feature ✨ This is enhancing something existing or creating something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with the text on the 'previous' button on the EVM opcodes page.
4 participants