Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert test suite to use declarative tool #158

Open
pipermerriam opened this issue Sep 6, 2019 · 0 comments
Open

Convert test suite to use declarative tool #158

pipermerriam opened this issue Sep 6, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@pipermerriam
Copy link
Member

What was wrong?

#140 introduced a declarative way to write implementation agnostic tests.

https://lahja.readthedocs.io/en/latest/api/testing.html

Some of the test suite has been converted to use this but not all of it.

How can it be fixed?

Take some or all of the remaining tests that are under ./tests/core/asyncio or ./tests/core/trio and rewrite them using the declarative tool. New tests should live under ./tests/core/common

@pipermerriam pipermerriam added the good first issue Good for newcomers label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant