Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devnet-5 problems (hive) #3854

Open
jochem-brouwer opened this issue Jan 29, 2025 · 1 comment
Open

Devnet-5 problems (hive) #3854

jochem-brouwer opened this issue Jan 29, 2025 · 1 comment

Comments

@jochem-brouwer
Copy link
Member

jochem-brouwer commented Jan 29, 2025

This run: https://github.com/ethpandaops/pectra-devnets/actions/runs/13014603440/job/36300526511 has found some faulty tests. Some might be false negatives (likely timeouts).

Here is what's failing:

Consume-Engine
Consume-Engine (only 1 test): https://hive.ethpandaops.io/pectra-devnet-5/suite.html?suiteid=1738099891-43f367743ed22043b76bdac6575c8a2b.json&suitename=eest%2Fconsume-engine#test-3568

src/pytest_plugins/consume/hive_simulators/engine/test_via_engine.py:60: in test_via_engine
    assert payload_response.status == (
E   AssertionError: unexpected status: status=<PayloadStatusEnum.VALID: 'VALID'> latest_valid_hash=b'\x1e\x93c\xe6\xec\x1aE\x8b\xd6OcV\xa3\xfauQ\xf9\x91\xeb\xaa_kNg\xe8\x03\xaa/\x1cw];' validation_error=None
E   assert <PayloadStatu...ALID: 'VALID'> == <PayloadStatu...ID: 'INVALID'>
E     - INVALID
E     ? --
E     + VALID

Description:

<br/><br/>Test function documentation:<br/><br/> Negative testing for all request types in the same block with incorrect parameters<br/> in the Engine API new payload parameters, but with the correct requests hash in the header<br/> so the block hash is correct.<br/><br/> In these tests, the requests hash in the header reflects what's actually in the executed block,<br/> so the block might execute properly if the client ignores the requests in the new payload<br/> parameters.<br/><br/

So seems like in newPayload there is a malformed request but the header is correct.

Consume RLP
The Consume RLP tests need a closer look, 1141/4246 failing. https://hive.ethpandaops.io/pectra-devnet-5/suite.html?suiteid=1738098485-27ae4e836c4a7c06866550bb4d81edd5.json&suitename=eest%2Fconsume-rlp

This all seems to have to do with invalid blocks, we report the wrong block hash, so I think this is a general issue when we import blocks via RLP.

@jochem-brouwer
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant