From cdde68669826ebfd50bbcc648261e4cf81ab5e46 Mon Sep 17 00:00:00 2001 From: alok Date: Fri, 14 Jul 2023 10:08:31 +0530 Subject: [PATCH] fix: adjust signals --- pkg/storer/reserve.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/pkg/storer/reserve.go b/pkg/storer/reserve.go index 757f6ce54fc..bf003473705 100644 --- a/pkg/storer/reserve.go +++ b/pkg/storer/reserve.go @@ -175,9 +175,8 @@ func (db *DB) evictionWorker(ctx context.Context) { db.metrics.ExpiryTriggersCount.Inc() if !expirySem.TryAcquire(1) { // if there is already a goroutine taking care of expirations dont wait - // for it to finish, instead schedule another run later if it is not - // already scheduled, this is to prevent pile up of expiration goroutines. - db.events.Trigger(batchExpiry) + // for it to finish. Cleanup is called from all cases, so we dont + // need to trigger everytime. return } defer expirySem.Release(1) @@ -259,9 +258,7 @@ func (db *DB) evictionWorker(ctx context.Context) { go func() { if !unreserveSem.TryAcquire(1) { // if there is already a goroutine taking care of unreserving - // dont wait for it to finish, instead schedule another run - // later if it is not already scheduled - db.events.Trigger(reserveOverCapacity) + // dont wait for it to finish return } defer unreserveSem.Release(1)