Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook messenger detected as Facebook #137

Open
usb248 opened this issue Nov 5, 2021 · 1 comment
Open

Facebook messenger detected as Facebook #137

usb248 opened this issue Nov 5, 2021 · 1 comment

Comments

@usb248
Copy link

usb248 commented Nov 5, 2021

⚠️ Missing/incorrect detections should be reported at https://github.com/matomo-org/device-detector/issues instead of this repo.

Or not ?

matomo-org/device-detector#6896

Tested with demo link : https://lx3rzx16x9.codesandbox.io/

@etienne-martin
Copy link
Owner

This should be fixed by upgrading this package to the latest version of Matomo (#134).

User-agent:

Mozilla/5.0 (iPhone; CPU iPhone OS 10_3_3 like Mac OS X) AppleWebKit/603.3.8 (KHTML, like Gecko) Mobile/14G60 LightSpeed [FBAN/MessengerLiteForiOS;FBAV/334.2.0.46.118;FBBV/324707651;FBDV/iPhone5,4;FBMD/iPhone;FBSN/iOS;FBSV/10.3.3;FBSS/2;FBCR/;FBID/phone;F

Wrong result (demo):

Should be detected as Facebook Messenger Lite but gets detected as Facebook.

{
  "client":{
    "type":"mobile app"
    "name":"Facebook"
    "version":"334.2"
  }
  "os":{
    "name":"iOS"
    "version":"10.3"
    "platform":""
  }
  "device":{
    "type":"smartphone"
    "brand":"Apple"
    "model":"iPhone 5C"
  }
  "bot":NULL
}

Expected result (matomo demo):

{
  "isBot": false,
  "clientInfo": {
    "type": "mobile app",
    "name": "Facebook Messenger Lite",
    "version": "334.2.0.46.118"
  },
  "browserFamily": null,
  "isMobileOnlyBrowser": false,
  "osInfo": {
    "name": "iOS",
    "short_name": "IOS",
    "version": "10.3.3",
    "platform": "",
    "family": "iOS"
  },
  "osFamily": "iOS",
  "device": 1,
  "deviceName": "smartphone",
  "deviceBrand": {
    "name": "Apple",
    "short_name": "AP"
  },
  "model": "iPhone 5C",
  "icons": {
    "browser": null,
    "os": "/icons/os/IOS.png",
    "device": "/icons/devices/smartphone.png",
    "brand": "/icons/brand/Apple.png"
  }
}

@etienne-martin etienne-martin changed the title Bad detection Facebook messenger detected as Facebook Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@usb248 @etienne-martin and others