Merge pull request #329 from europeana/EA-3896-fix-zoho-sync-deleted-…

…orgs delete only records which have deleted zoho record as proxy id #EA-3896
europeana · Jul 30, 2024 · a2c848d · a2c848d
2 parents f4f0659 + 8c617e5
commit a2c848d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/...anagement-web/src/main/java/eu/europeana/entitymanagement/web/service/BaseZohoAccess.java b/...anagement-web/src/main/java/eu/europeana/entitymanagement/web/service/BaseZohoAccess.java
@@ -131,6 +131,13 @@ protected void performOperations(BatchOperations operations, ZohoSyncReport zoho
 
   }
 
+  /**
+   * run permanent delete operations, use {@link ZohoSyncService#synchronizeDeletedZohoOrganizations(OffsetDateTime, ZohoSyncReport)}
+   * @deprecated the modified in zoho do not results in permanent delete operations
+   * @param permanentDeleteOperations operation to perform
+   * @param zohoSyncReport report to collect results
+   */
+  @Deprecated
   void performPermanentDeleteOperations(SortedSet<Operation> permanentDeleteOperations, ZohoSyncReport zohoSyncReport) {
     if (permanentDeleteOperations == null || permanentDeleteOperations.isEmpty()) {
       return;

diff --git a/...nagement-web/src/main/java/eu/europeana/entitymanagement/web/service/ZohoSyncService.java b/...nagement-web/src/main/java/eu/europeana/entitymanagement/web/service/ZohoSyncService.java
@@ -168,9 +168,8 @@ void synchronizeDeletedZohoOrganizations(OffsetDateTime modifiedSince,
     boolean hasNext = true;
     int currentPageSize = 0;
     List<String> entitiesZohoCoref = null;
-    // Zoho doesn't return the total results
-    List<EntityRecord> deletedEntityRecords;
     List<String> entityIdsToDelete;
+    // Zoho doesn't return the total results
     while (hasNext) {
       try {
         // list of (europeana) organizations ids