Ea 3545 spike json schema validation #37
Conversation
translation-web/pom.xml
Outdated
| --> | ||
|
|
||
| <dependency> | ||
| <groupId>com.networknt</groupId> |
There was a problem hiding this comment.
This dependency, shouldn't this be included in api-commons?
|
|
||
|
|
||
|
|
||
| private ObjectMapper objectMapper = new ObjectMapper(); |
There was a problem hiding this comment.
make sure to declare fields on the top
| private ObjectMapper objectMapper = new ObjectMapper(); | ||
|
|
||
| @Autowired | ||
| private ResourcePatternResolver resourcePatternResolver; |
There was a problem hiding this comment.
make sure to declare fields on the top
| @@ -33,7 +35,7 @@ public TranslationController(TranslationWebService translationService) { | |||
| @Tag(description = "Translation", name = "translate") | |||
| @PostMapping(value = {"/translate"}, | |||
| produces = {HttpHeaders.CONTENT_TYPE_JSON_UTF8, MediaType.APPLICATION_JSON_VALUE}) | |||
| public ResponseEntity<String> translate(@RequestBody TranslationRequest translRequest, | |||
| public ResponseEntity<String> translate(@ValidJson(uri = TranslationSchemaLocation.JSON_SCHEMA_URI, nested = TranslationSchemaLocation.JSON_SCHEMA_NESTED) TranslationRequest translRequest, | |||
There was a problem hiding this comment.
I think you need two nested json schema one for detect and one for translate. here we should use the translate one right?
|
|
||
| import eu.europeana.api.commons.JsonSchemaLocation; | ||
|
|
||
| public interface TranslationSchemaLocation extends JsonSchemaLocation { |
There was a problem hiding this comment.
this class contains our RND server location. These values should be added to the config file and accessed from there.
You can have the nested properties here.
But the only problem is if in the future we update or change the name, you need to make code changes and make a new release. If we add all this in the config file, we can easily redeploy. Better to add this in the config file, and access them.
I think we already have the TranslationConfig class where you can access them and use them in controller
| } | ||
|
|
||
|
|
||
| @ExceptionHandler(JsonValidationFailedException.class) |
There was a problem hiding this comment.
handler for the JsonValidationFailedException class should be added in EuropeanaGlobalExceptionHandler in api-commons.
This way this can be handled by any API using JSON schema validation.
| private ResourcePatternResolver resourcePatternResolver; | ||
|
|
||
| @Override | ||
| public void addArgumentResolvers(List<HandlerMethodArgumentResolver> resolvers) { |
There was a problem hiding this comment.
please add a comment why are we doing this. something like this -
/**
- we need to tell Spring about our JsonSchemaValidatingArgumentResolver.
- We do this by using the addArgumentResolvers(..) method from the WebMvcConfigurer interface.
- @param resolvers
*/
No description provided.