Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ENV vars rather than sourcing a script #69

Open
evanthegrayt opened this issue Sep 15, 2024 · 0 comments · May be fixed by #70
Open

Export ENV vars rather than sourcing a script #69

evanthegrayt opened this issue Sep 15, 2024 · 0 comments · May be fixed by #70

Comments

@evanthegrayt
Copy link
Owner

evanthegrayt commented Sep 15, 2024

Sourcing ~/.cdcrc is unnecessary, as it just sets variables that could be exported from ~/.bashrc or ~/.zshrc. This would also be safer, avoiding potentially malicious code in a file.

Rather than checking for the existence of the file, just check for the needed variables (really, just CDC_DIRS).

TODO:

  • Don't source a ~/.cdcrc file
  • Check for existence of CDC_DIRS
  • Remove -s option, which re-sources the file
  • Update documentation to instruct users to export CDC_DIRS and other variables.
@evanthegrayt evanthegrayt linked a pull request Sep 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant