From 83a611f4723bc1d329eae3acf1ed2ed81d5c5e6a Mon Sep 17 00:00:00 2001 From: Rasmus Mikkelsen Date: Sat, 12 Mar 2022 14:52:08 +0100 Subject: [PATCH 1/6] Add README to NuGet package --- Source/Common.props | 1 + 1 file changed, 1 insertion(+) diff --git a/Source/Common.props b/Source/Common.props index e9b0f3119..f96ee45e6 100644 --- a/Source/Common.props +++ b/Source/Common.props @@ -13,5 +13,6 @@ + From 617d72842189cb432ea7755d2f2d36ee9b6c39a5 Mon Sep 17 00:00:00 2001 From: Rasmus Mikkelsen Date: Sat, 12 Mar 2022 14:58:58 +0100 Subject: [PATCH 2/6] Upload NuGet packages to build --- .github/workflows/ci.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4c901144f..94b0b9c98 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -88,6 +88,14 @@ jobs: - name: Run Bake run: bake run --build-version 1.0.$GITHUB_RUN_NUMBER + - name: Upload NuGet packages + uses: actions/upload-artifact@v2 + if: success() || failure() + with: + name: packages + path: "**/*nupkg" + if-no-files-found: error + - name: Upload test results uses: actions/upload-artifact@v2 if: success() || failure() From 3965446a7ec80468f58b3065236a6f0294a40d5c Mon Sep 17 00:00:00 2001 From: Rasmus Mikkelsen Date: Sat, 12 Mar 2022 15:03:24 +0100 Subject: [PATCH 3/6] Bump version hack --- .github/workflows/ci.yml | 4 +++- .github/workflows/release.yml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 94b0b9c98..7362893d5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -86,7 +86,9 @@ jobs: run: dotnet tool install -g --version 0.12.24-beta Bake - name: Run Bake - run: bake run --build-version 1.0.$GITHUB_RUN_NUMBER + run: | + $VERSION = "1.0."+(5000+$($Env:GITHUB_RUN_NUMBER)) + bake run --build-version $VERSION - name: Upload NuGet packages uses: actions/upload-artifact@v2 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b0f41f7d9..72836fc7f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -86,7 +86,9 @@ jobs: run: dotnet tool install -g --version 0.12.24-beta Bake - name: Run Bake - run: bake-it/bake run --convention=Release --build-version 1.0.$GITHUB_RUN_NUMBER --destination="nuget>github,nuget,release>github" + run: | + $VERSION = "1.0."+(5000+$($Env:GITHUB_RUN_NUMBER)) + bake run --convention=Release --build-version $VERSION --destination="nuget>github,nuget,release>github" - name: Upload test results uses: actions/upload-artifact@v2 From 69ceb1f29dd47cbd28d5839b276b80bcf4c0b962 Mon Sep 17 00:00:00 2001 From: Rasmus Mikkelsen Date: Sat, 12 Mar 2022 15:12:27 +0100 Subject: [PATCH 4/6] Minor text additions --- MIGRATION_GUIDE.md | 12 +++++++----- RELEASE_NOTES.md | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/MIGRATION_GUIDE.md b/MIGRATION_GUIDE.md index 81ef5a418..bf8d2a5a6 100644 --- a/MIGRATION_GUIDE.md +++ b/MIGRATION_GUIDE.md @@ -13,12 +13,13 @@ public API surface. Here is the general motivation for introducing breaking changes to EventFlow. - The initial version of EventFlow had its own IoC and logger implementation, - but with the introduction of standardized `Microsoft.Extensions` packages, - many of these custom made implementations can be removed -- Focus on LTS versions of .NET (Core) and removing support .NET Framework. + but with the introduction of the standardized `Microsoft.Extensions` packages, + EventFlow's custom implementations are removed +- Focus on LTS versions of .NET (Core) and remove support .NET Framework as many + of the new C# language features are not available here - Fix misssssspelled API - Add obviously missing async/await on critical methods -- Remove non-async methods wrapper methods +- Remove non-async methods wrapper methods related to the bundled `AsyncHelper` ## Notable new features in 1.x @@ -39,7 +40,8 @@ that wasn't possible to add before as introducing them would cause breaking chan ``` If the connection string is not known at initialization, provide your own instance - of the `IMsSqlConfiguration` which now has a new method. + of the `IMsSqlConfiguration` which now has a new method that allows reading connection + strings at runtime. ```csharp Task GetConnectionStringAsync( diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 360d27d25..ff62d771b 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -27,7 +27,7 @@ https://github.com/eventflow/EventFlow/blob/develop-v1/MIGRATION_GUIDE.md - `MsSqlReadModelVersionColumn` * Breaking: Methods on `IMsSqlDatabaseMigrator` and `ISqlDatabaseMigrator` have been made async and have an extra `CancellationToken` argument -* Breaking: Remove support for .NET Framework and consolidate on .NET Core LTS versions +* Breaking: Remove support for .NET Framework and consolidate on .NET (Core) LTS versions * Breaking: Replace internal in-memory caching with `Microsoft.Extensions.Caching.Memory` * Breaking: Removed `IAmAsyncReadModelFor` and made `IAmReadModelFor` async * Breaking: Removed `EventFlow.Core.AsyncHelper` as well as all async wrapper methods From 16f4194d9f551527a741af4c8c11a01f3c25833e Mon Sep 17 00:00:00 2001 From: Rasmus Mikkelsen Date: Sat, 12 Mar 2022 15:17:53 +0100 Subject: [PATCH 5/6] Doh, use bash --- .github/workflows/ci.yml | 5 +++-- .github/workflows/release.yml | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7362893d5..a76229a81 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -87,8 +87,9 @@ jobs: - name: Run Bake run: | - $VERSION = "1.0."+(5000+$($Env:GITHUB_RUN_NUMBER)) - bake run --build-version $VERSION + declare -i REVISION + REVISION=5000+$GITHUB_RUN_NUMBER + bake run --build-version 1.0.$REVISION - name: Upload NuGet packages uses: actions/upload-artifact@v2 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 72836fc7f..9af8d0fee 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -87,8 +87,9 @@ jobs: - name: Run Bake run: | - $VERSION = "1.0."+(5000+$($Env:GITHUB_RUN_NUMBER)) - bake run --convention=Release --build-version $VERSION --destination="nuget>github,nuget,release>github" + declare -i REVISION + REVISION=5000+$GITHUB_RUN_NUMBER + bake run --convention=Release --build-version 1.0.$REVISION --destination="nuget>github,nuget,release>github" - name: Upload test results uses: actions/upload-artifact@v2 From 1aab01c3d4a41af6d81582f59157c278b8ac2e02 Mon Sep 17 00:00:00 2001 From: Rasmus Mikkelsen Date: Sat, 12 Mar 2022 15:21:07 +0100 Subject: [PATCH 6/6] Remove .NET Core 2.1 --- .github/workflows/ci.yml | 5 ----- .github/workflows/release.yml | 5 ----- 2 files changed, 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a76229a81..eb8518a2a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -62,11 +62,6 @@ jobs: - uses: actions/checkout@v2 - - name: Setup .NET Core 2.1.x - uses: actions/setup-dotnet@v1 - with: - dotnet-version: "2.1.x" - - name: Setup .NET Core 3.1.x uses: actions/setup-dotnet@v1 with: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9af8d0fee..bf10ce542 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -62,11 +62,6 @@ jobs: - uses: actions/checkout@v2 - - name: Setup .NET Core 2.1.x - uses: actions/setup-dotnet@v1 - with: - dotnet-version: "2.1.x" - - name: Setup .NET Core 3.1.x uses: actions/setup-dotnet@v1 with: