From a0fcca759e8011343404d66270d00c74c3a9d2b2 Mon Sep 17 00:00:00 2001
From: Archie Wood <58074498+archiewood@users.noreply.github.com>
Date: Fri, 14 Feb 2025 12:32:27 -0500
Subject: [PATCH 1/2] fix: height for maps and boxplot

---
 .changeset/tame-months-collect.md                 |  5 +++++
 .../lib/unsorted/viz/box/BoxPlot.stories.svelte   | 15 +++++++++++++++
 .../src/lib/unsorted/viz/box/BoxPlot.svelte       |  3 +++
 .../lib/unsorted/viz/map/AreaMap.stories.svelte   | 10 ++++++++++
 .../src/lib/unsorted/viz/map/_BaseMap.svelte      |  2 +-
 5 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/tame-months-collect.md

diff --git a/.changeset/tame-months-collect.md b/.changeset/tame-months-collect.md
new file mode 100644
index 0000000000..c62ce29615
--- /dev/null
+++ b/.changeset/tame-months-collect.md
@@ -0,0 +1,5 @@
+---
+'@evidence-dev/core-components': patch
+---
+
+Fix height prop in maps
diff --git a/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.stories.svelte b/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.stories.svelte
index d4266d914c..1738deb5e2 100644
--- a/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.stories.svelte
+++ b/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.stories.svelte
@@ -239,3 +239,18 @@ limit 50`,
 	)}
 	<BoxPlot {...args} {data} />
 </Story>
+
+<Story
+	name="Custom Height"
+	args={{
+		name: 'airline',
+		intervalBottom: 'min_fare',
+		midpoint: 'median_fare',
+		intervalTop: 'max_fare',
+		yFmt: 'usd0',
+		chartAreaHeight: 500
+	}}
+	let:args
+>
+	<BoxPlot {...args} data={flightData} />
+</Story>
\ No newline at end of file
diff --git a/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.svelte b/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.svelte
index 622a17913a..4cba3762f9 100644
--- a/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.svelte
+++ b/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.svelte
@@ -47,6 +47,8 @@
 	export let yMin = undefined;
 	export let yMax = undefined;
 	export let swapXY = false;
+	export let chartAreaHeight = undefined;
+
 
 	export let echartsOptions = undefined;
 	export let seriesOptions = undefined;
@@ -131,6 +133,7 @@
 	{title}
 	{subtitle}
 	chartType="Box Plot"
+	{chartAreaHeight}
 	{echartsOptions}
 	{seriesOptions}
 	{printEchartsConfig}
diff --git a/packages/ui/core-components/src/lib/unsorted/viz/map/AreaMap.stories.svelte b/packages/ui/core-components/src/lib/unsorted/viz/map/AreaMap.stories.svelte
index 9b398bf99f..0db841e3b7 100644
--- a/packages/ui/core-components/src/lib/unsorted/viz/map/AreaMap.stories.svelte
+++ b/packages/ui/core-components/src/lib/unsorted/viz/map/AreaMap.stories.svelte
@@ -179,3 +179,13 @@ ORDER BY 1;
 		legend="false"
 	/>
 </Story>
+
+<Story name="Custom height" parameters={{ chromatic: { disableSnapshot: true } }}>
+	<AreaMap
+		data={slow_la_zip_sales}
+		geoId="ZCTA5CE10"
+		value="sales"
+		areaCol="zip_code"
+		height=500
+	/>
+</Story>
diff --git a/packages/ui/core-components/src/lib/unsorted/viz/map/_BaseMap.svelte b/packages/ui/core-components/src/lib/unsorted/viz/map/_BaseMap.svelte
index cef369815a..ad32f42c5f 100644
--- a/packages/ui/core-components/src/lib/unsorted/viz/map/_BaseMap.svelte
+++ b/packages/ui/core-components/src/lib/unsorted/viz/map/_BaseMap.svelte
@@ -42,7 +42,7 @@
 		<EmptyChart slot="empty" {emptyMessage} {emptySet} {chartType} {isInitial} />
 		<ErrorChart let:loaded slot="error" title={chartType} error={error ?? loaded.error.message} />
 
-		<BaseMap {...$$restProps} title={undefined}>
+		<BaseMap {...$$restProps} title={undefined} {height}>
 			<slot data={loaded} />
 		</BaseMap>
 	</QueryLoad>

From bf4205c5b4b4e604bcf7e4d854a13222a510bb9d Mon Sep 17 00:00:00 2001
From: Archie Wood <58074498+archiewood@users.noreply.github.com>
Date: Fri, 14 Feb 2025 12:32:57 -0500
Subject: [PATCH 2/2] format

---
 .../src/lib/unsorted/viz/box/BoxPlot.stories.svelte             | 2 +-
 .../ui/core-components/src/lib/unsorted/viz/box/BoxPlot.svelte  | 1 -
 .../src/lib/unsorted/viz/map/AreaMap.stories.svelte             | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.stories.svelte b/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.stories.svelte
index 1738deb5e2..10285d328c 100644
--- a/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.stories.svelte
+++ b/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.stories.svelte
@@ -253,4 +253,4 @@ limit 50`,
 	let:args
 >
 	<BoxPlot {...args} data={flightData} />
-</Story>
\ No newline at end of file
+</Story>
diff --git a/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.svelte b/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.svelte
index 4cba3762f9..f27a8c29b4 100644
--- a/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.svelte
+++ b/packages/ui/core-components/src/lib/unsorted/viz/box/BoxPlot.svelte
@@ -49,7 +49,6 @@
 	export let swapXY = false;
 	export let chartAreaHeight = undefined;
 
-
 	export let echartsOptions = undefined;
 	export let seriesOptions = undefined;
 	export let printEchartsConfig = false;
diff --git a/packages/ui/core-components/src/lib/unsorted/viz/map/AreaMap.stories.svelte b/packages/ui/core-components/src/lib/unsorted/viz/map/AreaMap.stories.svelte
index 0db841e3b7..1e231a99c4 100644
--- a/packages/ui/core-components/src/lib/unsorted/viz/map/AreaMap.stories.svelte
+++ b/packages/ui/core-components/src/lib/unsorted/viz/map/AreaMap.stories.svelte
@@ -186,6 +186,6 @@ ORDER BY 1;
 		geoId="ZCTA5CE10"
 		value="sales"
 		areaCol="zip_code"
-		height=500
+		height="500"
 	/>
 </Story>