Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not checking signature of main in init code create from tx #441

Open
lrettig opened this issue Oct 8, 2018 · 1 comment
Open

Not checking signature of main in init code create from tx #441

lrettig opened this issue Oct 8, 2018 · 1 comment

Comments

@lrettig
Copy link
Member

lrettig commented Oct 8, 2018

This test fails: https://github.com/ewasm/tests/blob/f589b26f35fc7957f1a94b73a75f72b134a6bffa/src/GeneralStateTestsFiller/stEWASMTests/initMalformedBytecodeInvalidMainFromTxFiller.yml. The init code should be invalid because the signature for main is wrong, but the create succeeds.
@lrettig lrettig mentioned this issue Oct 9, 2018
Merged
@lrettig lrettig mentioned this issue Oct 25, 2018
Merged
@axic axic mentioned this issue Oct 25, 2018
Merged
@jwasinger
Copy link
Contributor

Seeing as this test was merged and the Hera CI is passing, can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lrettig @jwasinger