illegal opcode when main does not match signature on create (binaryen)

[lrettig]

Happens with both create opcode and create from tx. Sample init code wast:

        (module
          (import "ethereum" "finish" (func $finish (param i32 i32)))
          (memory 1)
          (export "memory" (memory 0))
          ;; signature does not match definition for $main
          (export "main" (func $main))

          (func $main (param i32)
            (call $finish
              (i32.const 0)
              (i32.const 0)
            )
          )
        )

error:

[2018-10-07 23:38:25.816431] [0x00007fffac722380] [info]    Loaded EVMC module: hera 0.1.0-dev+commit.a468d441 (/Users/lanerettig/eth/hera2/build/src/libhera.dylib)
Running tests using path: "/Users/lanerettig/eth/tests/"
Running 1 test case...
Test Case "stEWASMTests":
100%
Executing message in Hera
importGlobals
Function `$0` expects 1 parameters, got 0 arguments.
unknown location:0: fatal error: in "GeneralStateTests/stEWASMTests": signal: illegal opcode; address of failing instruction: 0x105225cd6
/Users/lanerettig/eth/cpp-ethereum/test/tools/libtesteth/TestHelper.cpp:595: last checkpoint

This happens only using binaryen; I see a different issue with wabt.

[axic]

Can you check with master?

[lrettig]

All good now, see ewasm/tests#96