Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Particles as Lost #47

Open
jtramm opened this issue Jan 17, 2024 · 0 comments
Open

Mark Particles as Lost #47

jtramm opened this issue Jan 17, 2024 · 0 comments

Comments

@jtramm
Copy link

jtramm commented Jan 17, 2024

The current implementation has commented out a number of areas where particles might be lost, and replaced it with a simple printf statement. It would be better to use the mark_as_lost_short() functions to ensure that the particle weights are set to zero. In adding some monitoring code and testing 100M particle histories on GPU, I'm seeing zero lost particles, but it would be good to add these calls back in and ensure lost particle treatments are working as expected. I'll also note that some of the more common lost particle checks are still in place, but this issue just highlights that a few of the less common ones are missing currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant