Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the workflow to run ci tests after a confirmation from the UI #132

Closed
3 tasks done
ahsimb opened this issue Jun 26, 2024 · 2 comments · Fixed by #136
Closed
3 tasks done

Change the workflow to run ci tests after a confirmation from the UI #132

ahsimb opened this issue Jun 26, 2024 · 2 comments · Fixed by #136
Assignees
Labels
refactoring Code improvement without behavior change

Comments

@ahsimb
Copy link
Collaborator

ahsimb commented Jun 26, 2024

This should be similar to how it is done in other repos, for instance in python-extension-common.

  • @ahsimb will mark slow tests with @pytest.mark.slow in the context of #119 and #120, resulting in 2 categories of tests:
    • C1) fast tests and
    • C2) slow tests
  • @ckunki will update the GitHub workflows to execute
    • the fast tests on each pull_request and
    • the slow ones only if manually confirmed.
  • Update Branch protection for Branch main to allow merging only if all tests have been executed and terminated successfully
    • CI / Gate 1 - Regular CI
    • CI / Gate 2 - Allow Merge
@ahsimb ahsimb added the refactoring Code improvement without behavior change label Jun 26, 2024
@ckunki ckunki self-assigned this Jun 26, 2024
@ckunki
Copy link
Contributor

ckunki commented Jun 27, 2024

Blocked by issue #120 Add tests with Exasol SaaS / PR #131

@ckunki
Copy link
Contributor

ckunki commented Jul 4, 2024

unblocked.

ckunki added a commit that referenced this issue Jul 4, 2024
ckunki added a commit that referenced this issue Jul 5, 2024
…nning slow tests (#136)

* #132: Updated GitHub workflows to request manual confirmation for running slow tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
2 participants