Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure common formatting of C++ code #974

Open
tomuben opened this issue Oct 8, 2024 · 0 comments
Open

Ensure common formatting of C++ code #974

tomuben opened this issue Oct 8, 2024 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented Oct 8, 2024

Background

Currently, there is no common formatting among the C++ code of the UDF client. We should use clang-format which could run as a commit githook.

Acceptance

  1. Define a .clang-format file which specifies the formatting
  2. Run clang-format and fix formatting
  3. Add a nox task which checks formatting
  4. Add nox task to Github workflow for CI checks.
@tomuben tomuben added the refactoring Code improvement without behavior change label Oct 8, 2024
@tomuben tomuben mentioned this issue Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomuben