From c53ce9e41a241d05802483fc5d16e6695dfdda6c Mon Sep 17 00:00:00 2001 From: Thomas Ubensee <34603111+tomuben@users.noreply.github.com> Date: Fri, 11 Oct 2024 16:07:59 -0300 Subject: [PATCH] Deactivate slow tests under valgrind --- .github/workflows/check_bazel_tests.yml | 8 ++++---- .../ctpg/test/script_option_lines_test.cpp | 4 ++++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check_bazel_tests.yml b/.github/workflows/check_bazel_tests.yml index 795aa3e3..0fd17715 100644 --- a/.github/workflows/check_bazel_tests.yml +++ b/.github/workflows/check_bazel_tests.yml @@ -27,13 +27,13 @@ jobs: name: "script_options_parser_ctpg" - test: "//base/script_options_parser/legacy/..." name: "script_options_parser_legacy" - - test: "--run_under='valgrind' //base/javacontainer/test:javacontainer-test-legacy-parser" + - test: "--run_under='valgrind' --copt -DVALGRIND_ACTIVE //base/javacontainer/test:javacontainer-test-legacy-parser" name: "javacontainer-test-legacy-parser-with-valgrind" - - test: "--run_under='valgrind' //base/javacontainer/test:javacontainer-test-ctpg-parser" + - test: "--run_under='valgrind' --copt -DVALGRIND_ACTIVE //base/javacontainer/test:javacontainer-test-ctpg-parser" name: "javacontainer-test-ctpg-parser-with-valgrind" - - test: "--run_under='valgrind' --test_timeout=3600 //base/script_options_parser/ctpg/..." + - test: "--run_under='valgrind' --copt -DVALGRIND_ACTIVE //base/script_options_parser/ctpg/..." name: "script_options_parser_ctpg_with_valgrind" - - test: "--run_under='valgrind' //base/script_options_parser/legacy/..." + - test: "--run_under='valgrind' --copt -DVALGRIND_ACTIVE //base/script_options_parser/legacy/..." name: "script_options_parser_legacy_with_valgrind" - test: "--config=asan //base/javacontainer/test:javacontainer-test-legacy-parser" name: "javacontainer-test-legacy-parser-with-asan" diff --git a/exaudfclient/base/script_options_parser/ctpg/test/script_option_lines_test.cpp b/exaudfclient/base/script_options_parser/ctpg/test/script_option_lines_test.cpp index f7cd3540..76ca72b0 100644 --- a/exaudfclient/base/script_options_parser/ctpg/test/script_option_lines_test.cpp +++ b/exaudfclient/base/script_options_parser/ctpg/test/script_option_lines_test.cpp @@ -17,6 +17,8 @@ inline ScriptOption buildOption(const char* value, size_t idx, size_t len) { return option; } +#ifndef VALGRIND_ACTIVE + class ScriptOptionLinesWhitespaceTest : public ::testing::TestWithParam> {}; TEST_P(ScriptOptionLinesWhitespaceTest, WhitespaceExtractOptionLineTest) { @@ -58,6 +60,8 @@ INSTANTIATE_TEST_SUITE_P( ) ); +#endif //VALGRIND_ACTIVE + TEST(ScriptOptionLinesTest, ignore_anything_other_than_whitepsace) { const std::string code = "abc %option myoption;\n"