From 6a9f818aee87ee48bb58af2fab3167b765bf74e7 Mon Sep 17 00:00:00 2001
From: Christoph Pirkl <christoph.pirkl@exasol.com>
Date: Thu, 14 Mar 2024 12:43:22 +0100
Subject: [PATCH] Add rationale for source & target configuration

---
 pom.xml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 55b0512..36b5134 100644
--- a/pom.xml
+++ b/pom.xml
@@ -174,11 +174,13 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <configuration>
-                    <!-- Override Java version -->
+                    <!-- We build for Java 8 but some test dependencies require JDK 11.
+                         So we build with JDK 11 and set source and target to 8.
+                         This requires excluding compiler warning below. -->
                     <source>8</source>
                     <target>8</target>
                     <compilerArgs>
-                        <!-- Excluding [options] bootstrap class path not set in conjunction with -source 8 -->
+                        <!-- Excluding "[options] bootstrap class path not set in conjunction with -source 8" -->
                         <arg>-Xlint:all,-processing,-path,-options</arg>
                         <arg>-Werror</arg>
                     </compilerArgs>