Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various small bugs in new_eff that were failing to handle window #761

Closed
wants to merge 1 commit into from

Conversation

yamaguchi1024
Copy link
Member

@yamaguchi1024 yamaguchi1024 commented Feb 21, 2025

Fixes #594

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (4bd40ca) to head (7eb5d3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   88.23%   88.29%   +0.06%     
==========================================
  Files          93       93              
  Lines       21625    21615      -10     
==========================================
+ Hits        19080    19085       +5     
+ Misses       2545     2530      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yamaguchi1024
Copy link
Member Author

stage_mem is not fixed in this PR, should probably fix it, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WindowStmt(s) aren't treated as declarative statements within the compiler
1 participant