Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Partial window of window support (second-order window) #762

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

akeley98
Copy link
Contributor

@akeley98 akeley98 commented Feb 21, 2025

This is not a complete implementation. Full support would require changing scheduling operators to recognize windows as tensors (e.g. as a source for stage_mem) and/or also have to avoid creating invalid T.Window types or AttributeError-ing due to treating a T.Window as if it were a T.Tensor.

The key helper function is LoopIR.create_window_type which takes care of "inlining" the indexing effects of two windows together.

Fixes #594

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 98.54015% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.34%. Comparing base (4bd40ca) to head (4302b63).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/exo/core/LoopIR.py 96.15% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
+ Coverage   88.23%   88.34%   +0.11%     
==========================================
  Files          93       93              
  Lines       21625    21716      +91     
==========================================
+ Hits        19080    19185     +105     
+ Misses       2545     2531      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akeley98 akeley98 changed the title WIP: Partial window of wIndow support (second-order window) WIP: Partial window of window support (second-order window) Feb 24, 2025
@akeley98 akeley98 merged commit 7194cdc into main Feb 24, 2025
9 checks passed
@akeley98 akeley98 deleted the akeley98/window_of_window branch February 24, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WindowStmt(s) aren't treated as declarative statements within the compiler
2 participants