Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch plugin doesn't work with "test" API keys #241

Open
jvgeee opened this issue Jun 26, 2024 · 3 comments
Open

Branch plugin doesn't work with "test" API keys #241

jvgeee opened this issue Jun 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@jvgeee
Copy link

jvgeee commented Jun 26, 2024

Library

https://github.com/expo/config-plugins/tree/main/packages/react-native-branch

Summary

When using Branch with the expo config-plugin, the plugin takes in an apiKey parameter. This adds an entry to the info.plist for:

<key>branch_key</key>
    <dict>
      <key>live</key>
      <string>key_xxxxx</string>
    </dict>

If you put a test key into your app.json config, then the SDK won't properly connect to the test environment of Branch; it still has a live key, and there's a mismatch, so none of your links can be properly processed by the SDK.

My requests:

  • Add a parameter for a testApiKey within the app.json config
  • Add a flag to enable debugging logs for Branch if possible

Any existing examples?

No response

@jvgeee jvgeee added the enhancement New feature or request label Jun 26, 2024
@jvgeee
Copy link
Author

jvgeee commented Jun 27, 2024

Was gonna make a PR for this but realised there already is one here that's been waiting for a review for months:

#229

@EvanBacon / @maintainers, can this be reviewed and merged in please?

@belle-chang
Copy link

+1, please review #229

@j3lev
Copy link

j3lev commented Sep 16, 2024

Any chance we could get please get eyes on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants