fix: Not fully compatible with [email protected], causing program errors

[wll8]

env

• [email protected]
• [email protected]
• [email protected] and [email protected]

see:

• path.replace is not a function pillarjs/path-to-regexp#333
• [email protected] #5902 (comment)

Code Analysis:

see:

• https://github.com/wll8/mockm/blob/5ecf970776674a2fc49b46f45b5ae49097f82df5/server/util/business.js#L68

• express/lib/application.js

  Line 489 in 7e562c6

  methods.forEach(function(method){

step:

• methods includes bind.
• Therefore, app has a bind function.
• The bind function can accept this, which is an object (path).
• However, in the bind function, this._router.route(path) receives this object.
• This object is passed to path-to-regexp.
• In path-to-regexp v0.1.7, the object is converted to a string without causing an error.
• In path-to-regexp v0.1.10, encountering an object can cause the program to crash.
• This is the reason for the program crash after the update.

The version that found the problem was 0.1.10, but this error was thrown in 0.1.11.

  if (typeof path !== 'string') {
    throw new TypeError('path must be a string, array of strings, or regular expression');
  }

imgA:

imgB:

In imgA, httpolyglot passed an object, which was concatenated into a string in path-to-regexp 0.1.7, and the program had no errors. However, in later versions of path-to-regexp, my use case ran into errors because the object could not be handled "friendly".

If you decide to upgrade path-to-regexp, should you keep old programs compatible without causing them to crash? What is the right way to do it? Do you not handle the app passed in when bind?

[NewEraCracker]

This is connected with: #5955 and #5975

Please check if any of the comments on #5955 can help you.

My two cents.

[wll8]

Deal with issues in a centralized location. #5955 and #5975