Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runkit tool from the hello world page #1625

Open
bjohansebas opened this issue Sep 17, 2024 · 2 comments · May be fixed by #1635
Open

Remove runkit tool from the hello world page #1625

bjohansebas opened this issue Sep 17, 2024 · 2 comments · May be fixed by #1635

Comments

@bjohansebas
Copy link
Member

It could be interesting if the page allowed you to run an Express server and test it directly, but we're using Runkit and it seems to always use Node 10

image

Since Express 5 requires Node.js 18, I think it's time to remove this tool as it can cause confusion in some cases due to the Node.js version (@expressjs/express-tc)

@crandmck
Copy link
Member

I believe you can pick the Node version from the dropdown, incl v 18:
Screenshot 2024-09-29 at 10 51 41 AM

Instead of removing it altogether, perhaps just say to set the required min version for the desired Express version...?

@crandmck
Copy link
Member

OK based on #1632 it seems it's not working at all, so yes let's get rid of it.

@bjohansebas bjohansebas linked a pull request Oct 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants