Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add support for local accounts #574

Closed
mrdvojo opened this issue Feb 9, 2025 · 2 comments
Closed

[BUG] Add support for local accounts #574

mrdvojo opened this issue Feb 9, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@mrdvojo
Copy link

mrdvojo commented Feb 9, 2025

Describe the bug
After 2.1, local account name is not displayed in user-module on top bar, as I did also report on discord but posting it here too, since it is still not fixed after couple of updates that were these past days.

To Reproduce
Steps to reproduce the behaviour:

  1. Use local account
  2. Instal Seelen UI

Expected behaviour
Well it should show name of the local account as it did before the rework of user-module

Screenshots
Image

Image

@mrdvojo mrdvojo added the bug Something isn't working label Feb 9, 2025
@eythaann eythaann changed the title [BUG] All its on fire!. [BUG] Add support for local accounts Feb 9, 2025
@eythaann eythaann moved this from Backlog to Ready in Seelen UI - Users Issues Feb 9, 2025
@luriusTM
Copy link
Contributor

Ok. First, local accounts works.

Image

It does not have display name configured, so you get back empty formatted string from winapi, which is correct.
This can be fixed with username instead of display name.
Altough a possible fix for this can be:
https://learn.microsoft.com/en-us/windows/win32/api/secext/nf-secext-getusernameexw
Image
Image works, but as much you never set up an image, the settig not exists, so it could show this (as it is), or the original fallback image, which is located:
C:\ProgramData\Microsoft\User Account Pictures\guest.*
Or can show an icon as none is there.

@luriusTM
Copy link
Contributor

Currently as I saw the code have removed the observation for local property changes, so you got to restart Seelen to the modification take effect

@luriusTM luriusTM moved this from Ready to In progress in Seelen UI - Users Issues Feb 11, 2025
luriusTM added a commit to luriusTM/Seelen-UI that referenced this issue Feb 12, 2025
luriusTM added a commit to luriusTM/Seelen-UI that referenced this issue Feb 12, 2025
@luriusTM luriusTM moved this from In progress to In review in Seelen UI - Users Issues Feb 12, 2025
luriusTM added a commit to luriusTM/Seelen-UI that referenced this issue Feb 12, 2025
@eythaann eythaann moved this from In review to Done in Seelen UI - Users Issues Feb 18, 2025
@eythaann eythaann closed this as completed by moving to Done in Seelen UI - Users Issues Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants