-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Songs on the right pages of the booklet are occasionally getting too close to the margin #44
Comments
Achieved when building with nix |
perhaps this? @Mast3rwaf1z |
In the interest of not yapping too much I'll look at this later. |
When you say "yap" you mean "commenting" right? |
I'm mostly referring to commenting my first thought every time it comes across, rather than writing a single comment in which only relevant information is found. |
This was because we were using an ancient version of (ghostscript?), but updating CI broke it. I'll take a look later |
I wish you would just use squash... this commit was very misleading because i undid a previous change in the same PR... anyway i've looked through both the booklet and the pdf, and it seems the issue is happening in the booklet right? the booklet does not use the flag that i changed in that PR, so that is also not what is causing the issue. A side note is that an issue just appearing like this gives me the impression that its probably due to the updated dependencies. EDIT: action seems to have been changed back to the older dependencies, confirming that its probably due to an update. if you check the artifact from action: https://github.com/f-klubben/sangbog/actions/runs/9800137287/artifacts/1669365391 it looks correct. |
Ty I'll take a look. |
I can confirm that it looks perfect when built through debian, so it's not the biggest hurry to fix it for nix. |
Neither am I, you know how fast that script was written :P |
Anyway, the issue remains, but as long as building through Debian works it won't be a high priority for me to figure out why it doesn't quite work with Nix. |
Looking at page 23, 31, 41 of the PDF you will witness text "overflowing"
The text was updated successfully, but these errors were encountered: