Crispy hangs when trying to launch netgame with Sigil or NRFTL

[SoDOOManiac]

Background

Version of Crispy Doom: 5.6.2

Operating System and version: Win 7 Professional x64

Game: Ultimate Doom, Doom 2 BFG

Any loaded WADs and mods (please include full command line):
start crispy-doom -iwad doom(3).wad -warp 51 -privateserver
start crispy-doom -iwad doom2(2).wad -episode 2 -privateserver

Bug description

Observed behavior: crispy-doom.exe process hangs in the task manager with no game window.

Expected behavior: the multiplayer game should launch as usual.

Reported by StasBFG(iddqd)

UPD: The same holds true for E1M10, MAP33 and NEIS's E1M0 and E4M0.

[fabiangreffrath]

So it chokes on all non-standard maps, interesting...

[fabiangreffrath]

This is a duplicate of this issue then, right?

chocolate-doom#875

[SoDOOManiac]

Chocolate's philosophy is to stay Vanilla, but this isn't the case for Crispy, so I decided to open this issue in Crispy tracker.

[fabiangreffrath]

Hm, okay, I'll leave this open, but don't have high hopes. The problem is that at this point in the netgame setup, we don't yet have any WAD data loaded and we simply don't have a better guess about what is a valid episode/map combination and what is not.

[SoDOOManiac]

OK, so will 5.6.3 be released without this?

[fabiangreffrath]

Definitely

[SoDOOManiac]

OK, I've prepared the changelog :)

[drfrag666]

For me it works in RUDE, you need to change the valid_modes[] struct in d_mode.c to support them.

[fabiangreffrath]

It's already there in Crispy.

[fabiangreffrath]

Ah, wait a minute, you mean the episode value, right?

[drfrag666]

Of course.

diff --git a/src/d_mode.c b/src/d_mode.c
index b3c9bb1c6..93c339eea 100644
--- a/src/d_mode.c
+++ b/src/d_mode.c
@@ -33,7 +33,7 @@ static struct
     { pack_chex, retail,     1, 5 },
     { doom,      shareware,  1, 9 },
     { doom,      registered, 3, 9 },
-    { doom,      retail,     4, 9 },
+    { doom,      retail,     5, 9 }, // SIGIL
     { doom2,     commercial, 1, 32 },
     { pack_tnt,  commercial, 1, 32 },
     { pack_plut, commercial, 1, 32 },

[SoDOOManiac]

So what are we doing with this? @drfrag666 proposed a solution that enables at least SIGIL.
For NRFTL, MAP33, E1M0-E4M0 extended levels netgame support, some base in Choco should be introduced first, I guess chocolate-doom#875

[fabiangreffrath]

It doesn't make sense to extend the number of accepted episodes and levels in Crispy, as long as there is no code that handles what to do when this number is exceeded in Choco.

[SoDOOManiac]

I'm looking forward to the respective changes in Choco then :)

[drfrag666]

I don't know what you mean, for me SIGIL works, I don't support the other ones tough. If i don't load SIGIL then Doom errors out as expected since it can't find the maps.

[fabiangreffrath]

Probably, but I want to preserve netgame compatibility with Choco, thus "Doom errors out" is not an option. The maximum episode or map mismatch must be detected at the network level when the connection is established. Is it not okay that all server and clients say "Ok!" and then one bombs out because "oops, this episode or map is not supported".