Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move [ERR] [ERROR] and similar to separate OpenType feature outside of calt #301

Open
svipas opened this issue Oct 7, 2024 · 5 comments

Comments

@svipas
Copy link

svipas commented Oct 7, 2024

When writing code in some cases it renders incorrectly, because ligatures like [ERR], [ERROR] are in calt. My suggestion is to move it to separate OpenType feature for e.g. ss15.

const [err] = someFn()
image
@fabrizioschiavi fabrizioschiavi moved this to To Do in 0.9 Oct 7, 2024
@fabrizioschiavi
Copy link
Owner

This makes sense. Thanks @svipas !

@matux
Copy link

matux commented Dec 27, 2024

Yes!

Screenshot 2024-12-27 at 6 25 23 PM

@fabrizioschiavi
Copy link
Owner

fabrizioschiavi commented Feb 11, 2025

I’m working at this issue,
could you please let me know which ligature must migrate to ss15 (optional tags) seeing this list?

  • [BUG]
  • [DEBUG]
  • [ERR]
  • [ERROR]
  • [FAIL]
  • [FATAL]
  • [FIXME]
  • [HACK]
  • [INFO]
  • [INFO ]
  • [KO]
  • [MARK]
  • [NOTE]
  • [OK]
  • [PASS]
  • [PASS ]
  • [TODO]
  • [TRACE]
  • [VERBOSE]
  • [WARN]
  • [WARN ]
  • [WARNING]

@wismill
Copy link

wismill commented Feb 11, 2025

I would say migrate either all of them or none, for consistency.

@svipas
Copy link
Author

svipas commented Feb 11, 2025

Yeah I do agree with @wismill here. Better to migrate all of them to ss15.

@fabrizioschiavi fabrizioschiavi moved this from To Do to Done in 0.9 Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants