Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id attributes not unique #24

Open
andy-mc-donald opened this issue Jul 12, 2019 · 0 comments
Open

id attributes not unique #24

andy-mc-donald opened this issue Jul 12, 2019 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@andy-mc-donald
Copy link

andy-mc-donald commented Jul 12, 2019

Lighthouse says:

[id] attributes on the page are not unique
Failing elements: ul#todo-block

I think what's happening here is you've set <ul id="todo-block"></ul> on line 15 of the <index.html> file.

Then in the dom.js file you're referencing it on line 62:

var todoBlock = document.getElementById("todo-block"); `

But then also setting the same id attribute in line 84:

todoListNode.setAttribute("id", "todo-block");

Could get around this by using class instead of id?

@andy-mc-donald andy-mc-donald added bug Something isn't working enhancement New feature or request labels Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant