Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits #32

Open
tonylomax opened this issue Nov 14, 2019 · 0 comments
Open

Commits #32

tonylomax opened this issue Nov 14, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@tonylomax
Copy link

I know Georgia mentioned this on Thursday and you've been co-authoring your commits nicely but things still look a little poorly balanced:

Screenshot 2019-11-14 at 19 33 03

It can be good practice to start a branch for a feature; do 20-30 mins on one computer, commit and push to the branch and then the other person in the pair pull that branch on their computer. You get equal commits and it ensures that both people have chance to backseat-drive. It can also be a great way to spot issues as you pull the new commits and read through the code.

Employers have been known to look through things like this and on first glance it looks like you've not been splitting things equally (even though we know you have!)

@tonylomax tonylomax added the enhancement New feature or request label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant