Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Enhancements #19

Open
10 tasks
itsina96 opened this issue Jun 12, 2020 · 0 comments
Open
10 tasks

CSS Enhancements #19

itsina96 opened this issue Jun 12, 2020 · 0 comments
Labels
code review enhancement New feature or request

Comments

@itsina96
Copy link

itsina96 commented Jun 12, 2020

How could the project be improved

  • More detailed README, e.g. need to npm install etc
  • At some point it will be worth considering refactoring your CSS with rem (pixels hard codes things like button height) and ensure em is only used where explicitly related to font size - and avoid setting these with px
  • 'How does it work' text - more attention could be bought to this by making the text bigger. Also, the arrow next to the text makes it unclear whether this is a dropdown menu for the user to click on
  • The answers text in the FAQs should be formatted differently, e.g. the questions could be in bold. However, another option would be to remove the FAQs section and just add the information elsewhere in the relevant sections or under 'How it works'
  • Individual underlines for the title, time, comments and rating (a tags) when they only direct to one endpoint and have them all highlighted in red when clicked feels a little bit awkward: maybe text-decoration: none for time, comments and rating?
  • Cursor: pointer; on go to workshops
  • Bigger text - also maybe set it once in one place rather than in every elements?
  • Maybe burger menu for navigation - so slide in and out
  • Could abstract your styled components into a neighbouring file to separate the styling
  • It also looks like there is a lot of button styling that makes small changes, it might be worth considering a more standardised styling across components that they can then share
@itsina96 itsina96 added enhancement New feature or request code review labels Jun 12, 2020
@VatsKan VatsKan changed the title Enhancements CSS Enhancements Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant