-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX/UI feedback #37
Comments
Wow @renatadev this is legendARY! |
FeedbackStorybookFantastic that you managed to use storybook with the amount of time you have for this project. You can also allow your stories to be displayed in different sizes and layouts in Storybook. This helps build responsive components inside of Storybook, mainly helpful as you’re design was made in a mobile, this is not a priority but it can be a nice thing to learn for the future, have a look here: https://github.com/storybookjs/storybook/tree/master/addons/viewport It’s all about the user
Styled components + buttonsOne of the main reasons for using syled components is to re-use the styles as much as possible. We don’t want to repeat ourselves over and over… Giving a standard style for our buttons will be a lot easier to re-utilize and to style on top of them. With this I mean, you should have one style for your standard button that will be implemented across the entire website and on top of that one sigle style you can implement variations of it. Have a look here and take a good look at the section called Adapting based on props and Extending Styles these are really helpful to know and to implement when some of the things we want to change are only bg colour/text colour/ etc. General I’m also completely amazed that you’ve implemented so many goodies in this project (like storybook), I’m loving it! You’re doing amaing! Keep it up. |
Amazing job 💫
Here's a little doc with some feedback
The text was updated successfully, but these errors were encountered: