Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help - how do we stop more pages from loading when the contact link is clicked? #48

Open
jackherizsmith opened this issue Apr 24, 2020 · 2 comments
Labels
bug Something isn't working code review help wanted Extra attention is needed

Comments

@jackherizsmith
Copy link
Collaborator

No description provided.

@jackherizsmith jackherizsmith added the help wanted Extra attention is needed label Apr 24, 2020
@akomiqaia
Copy link

  • function createdogelement() can use some cleanup.
    • all the event listeners can come out of the function
    • instead of creating all the dogs maybe create just one dog and then iterate in your home function. Like your function name is created dog element but what it serves is creating everything on the dom and you just call it in home() function with a dog object.
    • not sure if this can fix it but I am sure it is connected this. i have a good hanch

@HettieM
Copy link

HettieM commented Apr 24, 2020

(this isn't particularly helpful but) this also happens when you click on see other dogs on the page as well. As well as refreshing it appears to be adding everything again. Given that its happening both times I guess it's to do with the page coding rather than the contact link. My guess is that it might be something to do with the page appending rather than setting the inner html?

@jackherizsmith jackherizsmith added the bug Something isn't working label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code review help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants