From ca643f941fe70930e22eddf40c252384387e1d11 Mon Sep 17 00:00:00 2001 From: Artem Kholodnyi Date: Thu, 14 Dec 2023 07:58:07 -0800 Subject: [PATCH] Simplify catch clauses in PoolFactory Reviewed By: steelrooter Differential Revision: D52078065 fbshipit-source-id: 782830beda91faaa5b78ad4efceeb7f9229e312e --- .../imagepipeline/memory/PoolFactory.java | 35 ++----------------- 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/imagepipeline/src/main/java/com/facebook/imagepipeline/memory/PoolFactory.java b/imagepipeline/src/main/java/com/facebook/imagepipeline/memory/PoolFactory.java index 7ccf280935..8c269d558b 100644 --- a/imagepipeline/src/main/java/com/facebook/imagepipeline/memory/PoolFactory.java +++ b/imagepipeline/src/main/java/com/facebook/imagepipeline/memory/PoolFactory.java @@ -22,7 +22,6 @@ import com.facebook.imagepipeline.core.NativeCodeSetup; import com.facebook.infer.annotation.Nullsafe; import java.lang.reflect.Constructor; -import java.lang.reflect.InvocationTargetException; import javax.annotation.Nullable; import javax.annotation.concurrent.NotThreadSafe; @@ -107,15 +106,7 @@ public MemoryChunkPool getBufferMemoryChunkPool() { mConfig.getMemoryTrimmableRegistry(), mConfig.getMemoryChunkPoolParams(), mConfig.getMemoryChunkPoolStatsTracker()); - } catch (ClassNotFoundException e) { - mBufferMemoryChunkPool = null; - } catch (IllegalAccessException e) { - mBufferMemoryChunkPool = null; - } catch (InstantiationException e) { - mBufferMemoryChunkPool = null; - } catch (NoSuchMethodException e) { - mBufferMemoryChunkPool = null; - } catch (InvocationTargetException e) { + } catch (ReflectiveOperationException e) { mBufferMemoryChunkPool = null; } } @@ -149,19 +140,7 @@ public MemoryChunkPool getNativeMemoryChunkPool() { mConfig.getMemoryTrimmableRegistry(), mConfig.getMemoryChunkPoolParams(), mConfig.getMemoryChunkPoolStatsTracker()); - } catch (ClassNotFoundException e) { - FLog.e("PoolFactory", "", e); - mNativeMemoryChunkPool = null; - } catch (IllegalAccessException e) { - FLog.e("PoolFactory", "", e); - mNativeMemoryChunkPool = null; - } catch (InstantiationException e) { - FLog.e("PoolFactory", "", e); - mNativeMemoryChunkPool = null; - } catch (NoSuchMethodException e) { - FLog.e("PoolFactory", "", e); - mNativeMemoryChunkPool = null; - } catch (InvocationTargetException e) { + } catch (ReflectiveOperationException e) { FLog.e("PoolFactory", "", e); mNativeMemoryChunkPool = null; } @@ -183,15 +162,7 @@ private MemoryChunkPool getAshmemMemoryChunkPool() { mConfig.getMemoryTrimmableRegistry(), mConfig.getMemoryChunkPoolParams(), mConfig.getMemoryChunkPoolStatsTracker()); - } catch (ClassNotFoundException e) { - mAshmemMemoryChunkPool = null; - } catch (IllegalAccessException e) { - mAshmemMemoryChunkPool = null; - } catch (InstantiationException e) { - mAshmemMemoryChunkPool = null; - } catch (NoSuchMethodException e) { - mAshmemMemoryChunkPool = null; - } catch (InvocationTargetException e) { + } catch (ReflectiveOperationException e) { mAshmemMemoryChunkPool = null; } }