From 4fb7ab4c61defecff885a31eed6407df95ac76ad Mon Sep 17 00:00:00 2001 From: Kingsley Adio Date: Tue, 4 Feb 2025 03:21:08 -0800 Subject: [PATCH] Fix lint warnings in KComponent/PrimitiveComponent Summary: $title Reviewed By: pentiumao Differential Revision: D69059398 fbshipit-source-id: b8d003c54682386a9f5353f3e5ce6eaa3d56cd34 --- .../main/java/com/facebook/litho/KComponent.kt | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/litho-core/src/main/java/com/facebook/litho/KComponent.kt b/litho-core/src/main/java/com/facebook/litho/KComponent.kt index a699f2244b0..9e864e77a6e 100644 --- a/litho-core/src/main/java/com/facebook/litho/KComponent.kt +++ b/litho-core/src/main/java/com/facebook/litho/KComponent.kt @@ -29,7 +29,7 @@ abstract class KComponent : Component() { /** Method that will ensure the KComponent class is loaded. */ @JvmStatic - fun preload() = + fun preload(): KComponent = object : KComponent() { override fun ComponentScope.render(): Component? = null } @@ -129,26 +129,27 @@ abstract class KComponent : Component() { // All other Component lifecycle methods are made final and no-op here as they shouldn't be // overriden. - final override fun isEquivalentTo(other: Component?) = super.isEquivalentTo(other) + final override fun isEquivalentTo(other: Component?): Boolean = super.isEquivalentTo(other) - final override fun canMeasure() = false + final override fun canMeasure(): Boolean = false - final override fun getMountType() = super.getMountType() + final override fun getMountType(): MountType = super.getMountType() final override fun getSimpleName(): String = super.getSimpleName() - final override fun isPureRender() = false + final override fun isPureRender(): Boolean = false - final override fun makeShallowCopy() = super.makeShallowCopy() + final override fun makeShallowCopy(): Component = super.makeShallowCopy() - final override fun onCreateMountContent(context: Context) = super.onCreateMountContent(context) + final override fun onCreateMountContent(context: Context): Any = + super.onCreateMountContent(context) final override fun shouldUpdate( previous: Component, prevStateContainer: StateContainer?, next: Component, nextStateContainer: StateContainer? - ) = super.shouldUpdate(previous, prevStateContainer, next, nextStateContainer) + ): Boolean = super.shouldUpdate(previous, prevStateContainer, next, nextStateContainer) } /**