Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

CMake quoting "fix" breaks future versions of MSVC #32

Open
jaynus opened this issue Nov 22, 2014 · 0 comments
Open

CMake quoting "fix" breaks future versions of MSVC #32

jaynus opened this issue Nov 22, 2014 · 0 comments

Comments

@jaynus
Copy link

jaynus commented Nov 22, 2014

At Lib/LibStatic/CMakeLists.txt#L20 there is a hotfix to work around windows quoting issues, which conditional checks "some" vs compilers, which is a bit too restrictive.
IF( MSVC10 OR MSVC11 OR MSVC12 )

For VS2015 preview, which is build chain MSVC14, and any future MSVC's this will require additions to fix this. This causes the build to fail on the incorrect quote escaping.

The majority of the build system is already assuming MSVC chain on windows for definitions and arguments, the same should be assumed for these quoting mechanisms

IF(WIN32 AND NOT UNIX)

instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant