Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify actor-critic with shared layers #73

Open
panoskyriakis opened this issue Mar 5, 2024 · 2 comments
Open

Simplify actor-critic with shared layers #73

panoskyriakis opened this issue Mar 5, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@panoskyriakis
Copy link

The current implementation of ActorCriticBase makes it a bit trick to have custom actor and critic networks that have shared layers. This is because the instantiation of the networks happen in the ActorCriticBase class. You can probably get around it but it's very tricky. I'd recommend you pass in the actor/critic objects rather than the class types and let the user initialize them.

@jb3618columbia
Copy link
Contributor

Thank you for the comment. Yes, we have that planned for actor-critic methods. Note that for value based methods, we do give the option to users to pass in a network instance.

@jb3618columbia
Copy link
Contributor

Hi,

Just following up on this. We have updated the actor-critic base class to also be able to pass in actor and critic networks as arguments. Thank you for this suggestion. Please let us know if you notice any errors when using it. It will be helpful for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants