Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compute op coverage rate #121

Open
shengfukevin opened this issue May 31, 2024 · 0 comments
Open

Improve compute op coverage rate #121

shengfukevin opened this issue May 31, 2024 · 0 comments

Comments

@shengfukevin
Copy link
Contributor

et_replay skipped some operators, need to understand the reason why these operators are skipped, and how to fix it.

Some known ops:

  1. _scaled_dot_product_efficient_attention_backward_cuda (op schema does not support optional attention_bias)

  2. fbgemm for embedding table
    The current implementation tries to recover the embedding table lookup op from its forward call and backward call (The way to match the forward call and backward call is also fragil). It is not reliable as the op itself keep changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant