Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially rework CSS parsing #264

Open
facelessuser opened this issue Mar 8, 2023 · 0 comments
Open

Potentially rework CSS parsing #264

facelessuser opened this issue Mar 8, 2023 · 0 comments
Labels
C: css-parsing Related to CSS parsing. skip-triage Tells bot to not tag a new issue with 'triage'. T: feature Feature.

Comments

@facelessuser
Copy link
Owner

I'm considering a rewrite of the CSS parsing approach. We may take the approach of parsing the CSS as returning something like an AST. Then we would take that AST and make decisions about what is valid and what is invalid and construct our selector objects.

This could have the potential to make some of the internals more straightforward and make expanding the syntax easier. This is not really critical, but something to consider. As we have many tests in place, as long as we are able to produce the same results, we should be good.

@facelessuser facelessuser added T: feature Feature. C: css-parsing Related to CSS parsing. skip-triage Tells bot to not tag a new issue with 'triage'. labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: css-parsing Related to CSS parsing. skip-triage Tells bot to not tag a new issue with 'triage'. T: feature Feature.
Projects
None yet
Development

No branches or pull requests

1 participant